Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5005)

Issue 12949045: code review 12949045: runtime: integrated network pollster for netbsd/amd64,3... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by mikio
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, rsc, minux1
Visibility:
Public.

Description

runtime: integrated network pollster for netbsd/amd64,386,arm Original CL by minux (9545044). Update issue 6146

Patch Set 1 : diff -r 49d897ab8e2f https://code.google.com/p/go #

Patch Set 2 : diff -r 06593199ff39 https://code.google.com/p/go #

Patch Set 3 : diff -r 565e2d46bb68 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -12 lines) Patch
M src/pkg/runtime/defs_netbsd.go View 5 chunks +14 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_netbsd_386.h View 5 chunks +21 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_netbsd_amd64.h View 5 chunks +22 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_netbsd_arm.h View 5 chunks +22 lines, -2 lines 0 comments Download
M src/pkg/runtime/netpoll.goc View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/netpoll_kqueue.c View 2 chunks +3 lines, -2 lines 0 comments Download
M src/pkg/runtime/netpoll_stub.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/os_darwin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_freebsd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_netbsd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_openbsd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_netbsd_386.s View 1 chunk +29 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_netbsd_amd64.s View 1 chunk +31 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_netbsd_arm.s View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, minux.ma@gmail.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2013-08-17 02:38:48 UTC) #1
rsc
LGTM
10 years, 8 months ago (2013-08-17 02:42:42 UTC) #2
mikio
10 years, 8 months ago (2013-08-17 03:11:37 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4926812ec354 ***

runtime: integrated network pollster for netbsd/amd64,386,arm

Original CL by minux (9545044).

Update issue 6146

R=golang-dev, rsc
CC=golang-dev, minux.ma
https://codereview.appspot.com/12949045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b