Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 12922043: code review 12922043: time: handle GMT possibly with offset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by r
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

time: handle GMT possibly with offset Update issue 3790 Handle time zones like GMT-8. The more general time zone-matching problem is not yet resolved.

Patch Set 1 #

Patch Set 2 : diff -r 0794f26827a6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3ec140949606 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -19 lines) Patch
M src/pkg/time/format.go View 1 4 chunks +61 lines, -19 lines 0 comments Download
M src/pkg/time/time_test.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 7 months ago (2013-08-14 06:29:32 UTC) #1
rsc
LGTM
10 years, 7 months ago (2013-08-14 21:16:50 UTC) #2
r
10 years, 7 months ago (2013-08-15 00:11:00 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=210830b10a97 ***

time: handle GMT possibly with offset

Update issue 3790
Handle time zones like GMT-8.
The more general time zone-matching problem is not yet resolved.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12922043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b