code review 12916046: net: make protocol-specific Dial and Listen return cons...

net: make protocol-specific Dial and Listen return consistent error value

Update issue 4856

[mikio, 2013-08-18 10:27:33]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-08-22 00:42:19]

ping

[bradfitz, 2013-08-22 01:13:53]

I don't have time to review this.  R=Dave Cheney maybe?

I'm also slightly worried it's an API change, but it probably doesn't matter. 
It's already in weird error cases.

[mikio, 2013-08-22 05:55:13]

On 2013/08/22 01:13:53, bradfitz wrote:

> I'm also slightly worried it's an API change, but it probably doesn't matter. 
> It's already in weird error cases.

I think it's fine because this CL, and upcoming CLs won't break the existing
error notification tests; especially Temporary and Timeout.

Once this CL, a cleanup for communication connection setup error values,
lands on Go 1.2, we will do the rest except IO stuff in Go 1.3, and at last
controversial read/write I/O stuff.

[dave_cheney.net, 2013-08-22 11:55:50]

On 2013/08/22 05:55:13, mikio wrote:
> On 2013/08/22 01:13:53, bradfitz wrote:
> 
> > I'm also slightly worried it's an API change, but it probably doesn't
matter. 
> > It's already in weird error cases.
> 
> I think it's fine because this CL, and upcoming CLs won't break the existing
> error notification tests; especially Temporary and Timeout.
> 
> Once this CL, a cleanup for communication connection setup error values,
> lands on Go 1.2, we will do the rest except IO stuff in Go 1.3, and at last
> controversial read/write I/O stuff.

Hi Mikio,

Sorry that my travel scheduled has flared up recently. I'm reviewing this now.

@bradfitz looking at https://codereview.appspot.com/12763044, I think there is a
precedent that we can change the returned error values as part of this CL.

Cheers

Dave

[dave_cheney.net, 2013-08-22 12:20:22]

On 2013/08/22 11:55:50, dfc wrote:
> On 2013/08/22 05:55:13, mikio wrote:
> > On 2013/08/22 01:13:53, bradfitz wrote:
> > 
> > > I'm also slightly worried it's an API change, but it probably doesn't
> matter. 
> > > It's already in weird error cases.
> > 
> > I think it's fine because this CL, and upcoming CLs won't break the existing
> > error notification tests; especially Temporary and Timeout.
> > 
> > Once this CL, a cleanup for communication connection setup error values,
> > lands on Go 1.2, we will do the rest except IO stuff in Go 1.3, and at last
> > controversial read/write I/O stuff.
> 
> Hi Mikio,
> 
> Sorry that my travel scheduled has flared up recently. I'm reviewing this now.
> 
> @bradfitz looking at https://codereview.appspot.com/12763044, I think there is
a
> precedent that we can change the returned error values as part of this CL.
> 
> Cheers
> 
> Dave

Could you please hg mail this again,

localhost(~/go/src/pkg/net) % hg clpatch 12916046
abort: codereview issue 12916046 is out of date: patch and recent changes
conflict (9b8afda16f02->037a28ab0725)

[mikio, 2013-08-23 01:10:21]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2013-08-27 02:36:32]

ping

[bradfitz, 2013-08-29 00:41:17]

LGTM



On Mon, Aug 26, 2013 at 7:36 PM, <mikioh.mikioh@gmail.com> wrote:

> ping
>
>
https://codereview.appspot.**com/12916046/<https://codereview.appspot.com/129...
>

[mikio, 2013-08-29 01:27:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=05371b52fa00 ***

net: make protocol-specific Dial and Listen return consistent error value

Update issue 4856

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/12916046