code review 128950043: A Taste of Go: present slides

A Taste of Go: present slides

[dsymonds, 2014-08-13 05:57:42]

looks nice; just a few nits.

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode34
2014/taste.slide:34: - Mathematically precise:
ironic, since the next line is *not* a mathematically precise version of e, but
rather an approximation.

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode385
2014/taste.slide:385: ch := make(chan int)  // declare and intialize with newly
made channel
typo: "initialize"

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode387
2014/taste.slide:387: A channel permits _sending_ and _receiving_ values between
goroutines:
I might elide "between goroutines", since it's possible to send/recv within the
same goroutine if the channel is buffered.

[cmang, 2014-08-13 06:25:54]

I really like the Sequential to Concurrent histogram example, it ties the
presentation together well.

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode66
2014/taste.slide:66: - Predeclared types: The usual suspects
Mention error type here since it gets used in later slides.

[iant, 2014-08-13 13:23:52]

Looks good.  My only comment is that this is a long talk.  How long do you have?

[gri, 2014-08-13 17:06:12]

PTAL

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode34
2014/taste.slide:34: - Mathematically precise:
On 2014/08/13 05:57:42, dsymonds wrote:
> ironic, since the next line is *not* a mathematically precise version of e,
but
> rather an approximation.

Acknowledged.

I'll think of a better example (e.g., 1/3 that is than used to create a valid
int value).

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode66
2014/taste.slide:66: - Predeclared types: The usual suspects
On 2014/08/13 06:25:54, cmang wrote:
> Mention error type here since it gets used in later slides.

Done.

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode385
2014/taste.slide:385: ch := make(chan int)  // declare and intialize with newly
made channel
On 2014/08/13 05:57:42, dsymonds wrote:
> typo: "initialize"

Done.

https://codereview.appspot.com/128950043/diff/140001/2014/taste.slide#newcode387
2014/taste.slide:387: A channel permits _sending_ and _receiving_ values between
goroutines:
On 2014/08/13 05:57:42, dsymonds wrote:
> I might elide "between goroutines", since it's possible to send/recv within
the
> same goroutine if the channel is buffered.

Done.

[gri, 2014-08-13 17:07:51]

On Wed, Aug 13, 2014 at 6:23 AM, <iant@golang.org> wrote:

> Looks good.  My only comment is that this is a long talk.  How long do
> you have?
>

I have approx. an hour. I am aware of the length and will try to trim some
unnecessary stuff - perhaps not be super-detailed with each slide.
- gri

Slides may be visible at: http://gri-macmini.local:3999/taste.slide#1

[gri, 2014-08-14 23:36:39]

Hello dsymonds@golang.org, cmang@golang.org, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[kortschak, 2014-08-15 01:21:41]

That is a very nice talk.

[dfc, 2014-08-16 01:53:53]

LGTM. Excellent talk, so much more concise and engaging than my recent effort.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode33
2014/taste.slide:33: * Hello, World! internet-style
Capital I after exclamation point ?

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode95
2014/taste.slide:95: [10]byte
other examples further on have a little comment annotating the type, maybe add

[10]byte  // an array of 10 bytes

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode118
2014/taste.slide:118: - Descriptor for an underlying array segment
Is there another word you could use for 'segment' ? maybe just drop segment.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode149
2014/taste.slide:149: - Map iteration order is random (enforced):
nit: iteration order is not specified, not specified to be random.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode181
2014/taste.slide:181: (Rob Pike)
suggestion; use emdash Rob Pike

It would be excellent if present grew something like 

.blockquote

for this use case

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode185
2014/taste.slide:185:
_Compactness_of_syntax_doesn't_matter_unless_you_are_reading_programs._
attribution ?

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode325
2014/taste.slide:325: cat $(find $GOROOT -name '*.go') | ./idents | sort | uniq
-c | sort -nr | sed 10q
I guess you copy this into a shell and run it during the talk. maybe you could
format this as code and put a $ in front to make it look like a shell command

[josharian, 2014-08-18 18:27:34]

Nice.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode48
2014/taste.slide:48: - Evaluated a compile-time:
s/a/at/

[jscrockett01, 2014-08-18 19:12:41]

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode77
2014/taste.slide:77: int8, int16, int32, int32 (rune),
uint64, int64?

[gri, 2014-08-19 22:41:51]

Thanks for the extra round of feedback.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide
File 2014/taste.slide (right):

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode33
2014/taste.slide:33: * Hello, World! internet-style
On 2014/08/16 01:53:53, dfc wrote:
> Capital I after exclamation point ?

Done.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode48
2014/taste.slide:48: - Evaluated a compile-time:
On 2014/08/18 18:27:33, josharian wrote:
> s/a/at/

Done.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode77
2014/taste.slide:77: int8, int16, int32, int32 (rune),
On 2014/08/18 19:12:40, jscrockett01 wrote:
> uint64, int64?

nice catch!

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode95
2014/taste.slide:95: [10]byte
On 2014/08/16 01:53:53, dfc wrote:
> other examples further on have a little comment annotating the type, maybe add
> 
> [10]byte  // an array of 10 bytes

Done.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode118
2014/taste.slide:118: - Descriptor for an underlying array segment
On 2014/08/16 01:53:53, dfc wrote:
> Is there another word you could use for 'segment' ? maybe just drop segment.

prefer leaving as is

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode149
2014/taste.slide:149: - Map iteration order is random (enforced):
On 2014/08/16 01:53:53, dfc wrote:
> nit: iteration order is not specified, not specified to be random.

Done.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode181
2014/taste.slide:181: (Rob Pike)
On 2014/08/16 01:53:53, dfc wrote:
> suggestion; use emdash Rob Pike
> 
> It would be excellent if present grew something like 
> 
> .blockquote
> 
> for this use case

Done.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode185
2014/taste.slide:185:
_Compactness_of_syntax_doesn't_matter_unless_you_are_reading_programs._
On 2014/08/16 01:53:53, dfc wrote:
> attribution ?

Mine, so I left it off.

https://codereview.appspot.com/128950043/diff/320001/2014/taste.slide#newcode325
2014/taste.slide:325: cat $(find $GOROOT -name '*.go') | ./idents | sort | uniq
-c | sort -nr | sed 10q
On 2014/08/16 01:53:52, dfc wrote:
> I guess you copy this into a shell and run it during the talk. maybe you could
> format this as code and put a $ in front to make it look like a shell command

Done.

PS: I did run it in a shell as an example.

[gri, 2014-08-19 22:42:49]

*** Submitted as
https://code.google.com/p/go/source/detail?r=cb9826e65264&repo=talks ***

A Taste of Go: present slides

LGTM=dave
R=dsymonds, cmang, iant, dan.kortschak, dave, josharian, jscrockett01
CC=golang-codereviews
https://codereview.appspot.com/128950043