Issue 128940043: code review 128940043: [release-branch.go1.3] cmd/cgo: fix recursive type mapping

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 128940043: code review 128940043: [release-branch.go1.3] cmd/cgo: fix recursive type mapping (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by adg

Modified:
9 years, 8 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] cmd/cgo: fix recursive type mapping ««« CL 122850043 / 0015a2541545 cmd/cgo: fix recursive type mapping Instead of immediately completing pointer type mappings, add them to a queue to allow them to be completed later. This fixes issues caused by Type() returning arbitrary in-progress type mappings. Fixes issue 8368. Fixes issue 8441. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/122850043 Committer: Ian Lance Taylor <iant@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r a105718684919cc50609e0d6d730903b9ad84387 https://code.google.com/p/go #

Patch Set 3 : diff -r a105718684919cc50609e0d6d730903b9ad84387 https://code.google.com/p/go #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -13 lines)			Patch
	A	misc/cgo/test/issue8441.go	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/gcc.go	View	1	8 chunks	+44 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 8 months ago (2014-08-11 23:40:39 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=4e9360fa753d *** [release-branch.go1.3] cmd/cgo: fix recursive type mapping ««« CL 122850043 / ...

9 years, 8 months ago (2014-08-11 23:43:00 UTC) #2

gobot

9 years, 8 months ago (2014-08-12 17:56:13 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/ac06746845645f509b06da7087be7899ac46892b

Expand All Messages | Collapse All Messages