Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5210)

Issue 128930044: code review 128930044: [release-branch.go1.3] crypto/rsa: fix out-of-bound acc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] crypto/rsa: fix out-of-bound access with short session keys. ««« CL 102670044 / c5f72a685e25 crypto/rsa: fix out-of-bound access with short session keys. Thanks to Cedric Staub for noting that a short session key would lead to an out-of-bounds access when conditionally copying the too short buffer over the random session key. LGTM=davidben, bradfitz R=davidben, bradfitz CC=golang-codereviews https://codereview.appspot.com/102670044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 4e9360fa753d7cdcd22b4fcdcbc8d2b26c49cfbc https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -17 lines) Patch
M src/pkg/crypto/rsa/pkcs1v15.go View 1 5 chunks +28 lines, -15 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15_test.go View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/pkg/crypto/subtle/constant_time.go View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-08-11 23:45:03 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=58ee390ff316 *** [release-branch.go1.3] crypto/rsa: fix out-of-bound access with short session keys. ««« ...
9 years, 8 months ago (2014-08-11 23:45:23 UTC) #2
rsc
9 years, 8 months ago (2014-08-11 23:55:33 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b