code review 12880043: sync/atomic: update comment for ARM 64-bit atomics

sync/atomic: update comment for ARM 64-bit atomics

They don't work on older chips, just like the x86-32 64-bit atomics.

Update issue 6134

[rsc, 2013-08-13 19:25:41]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-13 19:27:54]

LGTM



On Tue, Aug 13, 2013 at 12:25 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> sync/atomic: update comment for ARM 64-bit atomics
>
> They don't work on older chips, just like the x86-32 64-bit atomics.
>
> Update issue 6134
>
> Please review this at
https://codereview.appspot.**com/12880043/<https://codereview.appspot.com/128...
>
> Affected files:
>   M src/pkg/sync/atomic/doc.go
>
>
> Index: src/pkg/sync/atomic/doc.go
> ==============================**==============================**=======
> --- a/src/pkg/sync/atomic/doc.go
> +++ b/src/pkg/sync/atomic/doc.go
> @@ -47,6 +47,8 @@
>
>  // BUG(rsc): On x86-32, the 64-bit functions use instructions unavailable
> before the Pentium MMX.
>  //
> +// On non-Linux ARM, the 64-bit functions use instructions unavailable
> before the ARMv6k core.
> +//
>  // On both ARM and x86-32, it is the caller's responsibility to arrange
> for 64-bit
>  // alignment of 64-bit words accessed atomically. The first word in a
> global
>  // variable or in an allocated struct or slice can be relied upon to be
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-08-13 20:16:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=827764ef09ec ***

sync/atomic: update comment for ARM 64-bit atomics

They don't work on older chips, just like the x86-32 64-bit atomics.

Update issue 6134

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12880043