code review 12869049: os/exec: remove flaky TestExtraFilesFDShuffle test

os/exec: remove flaky TestExtraFilesFDShuffle test

Update issue 5780

[cshapiro, 2013-08-23 23:34:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[cshapiro1, 2013-08-23 23:36:35]

I would not be heartbroken if someone comes up with a better fix and we pass on
this change.  However, this test has been flaky for a very long time and breaks
every fresh checkout I make.  There has been much discussion about what to do
but no progress.  

Removing it seems like the best way to proceed for the time being.  We can
always add a working test that covers the same functionality, sometime later.

[dfc, 2013-08-23 23:38:23]

SGTM, but please don't close issue 5780. 

On 24/08/2013, at 9:36, cshapiro@google.com wrote:

> I would not be heartbroken if someone comes up with a better fix and we
> pass on this change.  However, this test has been flaky for a very long
> time and breaks every fresh checkout I make.  There has been much
> discussion about what to do but no progress.
> 
> Removing it seems like the best way to proceed for the time being.  We
> can always add a working test that covers the same functionality,
> sometime later.
> 
> https://codereview.appspot.com/12869049/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[cshapiro1, 2013-08-23 23:40:37]

On Fri, Aug 23, 2013 at 4:38 PM, Dave Cheney <dave@cheney.net> wrote:

> SGTM, but please don't close issue 5780.


Sure.  I have re-uploaded with an update instead of a fix.  If someone
wants to roll back this change when a real fix is in, the change will be
recorded in the issue.  Does that sound okay to you?

[dfc, 2013-08-23 23:43:45]

LGTM. 

Should say Update issue (singular)

On 24/08/2013, at 9:34, cshapiro@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/
> 
> 
> Description:
> os/exec: remove flaky TestExtraFilesFDShuffle test
> 
> Fixes issue 5780
> 
> Please review this at https://codereview.appspot.com/12869049/
> 
> Affected files:
>  M src/pkg/os/exec/exec_test.go
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[bradfitz, 2013-08-23 23:47:14]

I would prefer just a one line addition:

t.Skip("flaky test; see golang.org/issue/nnnn")
 On Aug 23, 2013 6:34 PM, <cshapiro@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> os/exec: remove flaky TestExtraFilesFDShuffle test
>
> Fixes issue 5780
>
> Please review this at
https://codereview.appspot.**com/12869049/<https://codereview.appspot.com/128...
>
> Affected files:
>   M src/pkg/os/exec/exec_test.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[cshapiro1, 2013-08-23 23:53:18]

On 2013/08/23 23:47:14, bradfitz wrote:
> I would prefer just a one line addition:
> 
> t.Skip("flaky test; see golang.org/issue/nnnn")

Done.

[cshapiro, 2013-08-23 23:53:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=a0c9efade7f4 ***

os/exec: remove flaky TestExtraFilesFDShuffle test

Update issue 5780

R=golang-dev, cshapiro, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/12869049