code review 128650043: net: Fixes IPNet.String() to work on non-pointers

net: Fixes IPNet.String() to work on non-pointers

Fixes issue 8575.

[vishvananda, 2014-08-23 01:20:11]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com, vishvananda@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go

[vishvananda, 2014-08-23 01:23:23]

I couldn't get the change to submit without adding myself to the contributors
file. Looking at the
changelog it appears that this is generally done via some kind of automation? I
have signed the
CLA so hopefully that goes through and I can remove the CONTRIBUTORS change from
this
commit.

[minux, 2014-08-23 02:06:42]

NOT LGTM.

This is an API change.

issue 8575 is working as intended.

[vishvananda, 2014-08-23 02:15:09]

On 2014/08/23 02:06:42, minux wrote:
> NOT LGTM.
> 
> This is an API change.
> 
> issue 8575 is working as intended.

Is adding a new String method for non-pointer receivers an acceptable change? or
does that also violate API compatibility?

[vishvananda, 2014-08-23 02:17:01]

On 2014/08/23 02:15:09, vishvananda wrote:
> On 2014/08/23 02:06:42, minux wrote:
> > NOT LGTM.
> > 
> > This is an API change.
> > 
> > issue 8575 is working as intended.
> 
> Is adding a new String method for non-pointer receivers an acceptable change?
or
> does that also violate API compatibility?

Ok scratch that golang doesn't allow two methods defined. OK will abandon this,
thank you.

[iant, 2014-08-23 12:57:21]

Please take the CONTRIBUTORS change out of this CL.  You can have it in your
local repository, just not in this CL.

[gobot, 2014-12-19 05:12:04]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/128650043 is best) in the description in your
new CL.

Thanks very much.