code review 128350044: time: use go generate rather than Makefile (windows only)

time: use go generate rather than Makefile (windows only)
Also make genzabbrs.go more self-contained.
Also run it (on Linux; does that matter?) to update the table.

[r, 2014-08-26 18:09:51]

Hello rsc, brainman (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-08-26 19:45:05]

LGTM

https://codereview.appspot.com/128350044/diff/1/src/pkg/time/genzabbrs.go
File src/pkg/time/genzabbrs.go (right):

https://codereview.appspot.com/128350044/diff/1/src/pkg/time/genzabbrs.go#new...
src/pkg/time/genzabbrs.go:10: // go build genzabbrs.go && ./genzabbrs -output
zoneinfo_abbrs_windows.go
go run genzabbrs.go -output zoneinfo_abbrs_windows.go
?

https://codereview.appspot.com/128350044/diff/1/src/pkg/time/zoneinfo_windows.go
File src/pkg/time/zoneinfo_windows.go (right):

https://codereview.appspot.com/128350044/diff/1/src/pkg/time/zoneinfo_windows...
src/pkg/time/zoneinfo_windows.go:14: //go:generate go run genzabbrs.go
-output zoneinfo_abbrs_windows.go

[r, 2014-08-26 21:45:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=59b1bb4bf045 ***

time: use go generate rather than Makefile (windows only)
Also make genzabbrs.go more self-contained.
Also run it (on Linux; does that matter?) to update the table.

LGTM=rsc
R=rsc, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/128350044

[brainman, 2014-08-27 03:27:18]

LGTM

Very nice. Thank you very much.

But why changes to zoneinfo_abbrs_windows.go? Running it on Linux now:

# hg id
59b1bb4bf045 tip
# hg st
# go generate zoneinfo_windows.go
# hg diff
diff -r 59b1bb4bf045 src/pkg/time/zoneinfo_abbrs_windows.go
--- a/src/pkg/time/zoneinfo_abbrs_windows.go	Tue Aug 26 14:45:53 2014 -0700
+++ b/src/pkg/time/zoneinfo_abbrs_windows.go	Wed Aug 27 13:21:37 2014 +1000
@@ -13,7 +13,7 @@
 }
 
 var abbrs = map[string]abbr{
-	"Egypt Standard Time":             {"EET", "EEST"},   // Africa/Cairo
+	"Egypt Standard Time":             {"EET", "EET"},    // Africa/Cairo
 	"Morocco Standard Time":           {"WET", "WEST"},   // Africa/Casablanca
 	"South Africa Standard Time":      {"SAST", "SAST"},  // Africa/Johannesburg
 	"W. Central Africa Standard Time": {"WAT", "WAT"},    // Africa/Lagos
@@ -22,7 +22,7 @@
 	"Namibia Standard Time":           {"WAT", "WAST"},   // Africa/Windhoek
 	"Alaskan Standard Time":           {"AKST", "AKDT"},  // America/Anchorage
 	"Paraguay Standard Time":          {"PYT", "PYST"},   // America/Asuncion
-	"Bahia Standard Time":             {"BRT", "BRT"},    // America/Bahia
+	"Bahia Standard Time":             {"BRT", "BRST"},   // America/Bahia
 	"SA Pacific Standard Time":        {"COT", "COT"},    // America/Bogota
 	"Argentina Standard Time":         {"ART", "ART"},    // America/Buenos_Aires
 	"Venezuela Standard Time":         {"VET", "VET"},    // America/Caracas
@@ -105,9 +105,9 @@
 	"Romance Standard Time":          {"CET", "CEST"},      // Europe/Paris
 	"Central European Standard Time": {"CET", "CEST"},      // Europe/Warsaw
 	"Mauritius Standard Time":        {"MUT", "MUT"},       // Indian/Mauritius
-	"Samoa Standard Time":            {"WST", "WSDT"},      // Pacific/Apia
+	"Samoa Standard Time":            {"WST", "WST"},       // Pacific/Apia
 	"New Zealand Standard Time":      {"NZST", "NZDT"},     // Pacific/Auckland
-	"Fiji Standard Time":             {"FJT", "FJST"},      // Pacific/Fiji
+	"Fiji Standard Time":             {"FJT", "FJT"},       // Pacific/Fiji
 	"Central Pacific Standard Time":  {"SBT", "SBT"},       // Pacific/Guadalcanal
 	"Hawaiian Standard Time":         {"HST", "HST"},       // Pacific/Honolulu
 	"Line Islands Standard Time":     {"LINT", "LINT"},     // Pacific/Kiritimati

Is it possible that you download different file from me?

Alex

[r, 2014-08-27 03:57:27]

I ran it and that's what happened. If you'd rather revert or update it
differently, feel free.

-rob


On Tue, Aug 26, 2014 at 8:27 PM,  <alex.brainman@gmail.com> wrote:
> LGTM
>
> Very nice. Thank you very much.
>
> But why changes to zoneinfo_abbrs_windows.go? Running it on Linux now:
>
> # hg id
> 59b1bb4bf045 tip
> # hg st
> # go generate zoneinfo_windows.go
> # hg diff
> diff -r 59b1bb4bf045 src/pkg/time/zoneinfo_abbrs_windows.go
> --- a/src/pkg/time/zoneinfo_abbrs_windows.go    Tue Aug 26 14:45:53 2014
> -0700
> +++ b/src/pkg/time/zoneinfo_abbrs_windows.go    Wed Aug 27 13:21:37 2014
> +1000
> @@ -13,7 +13,7 @@
>  }
>
>  var abbrs = map[string]abbr{
> -       "Egypt Standard Time":             {"EET", "EEST"},   //
> Africa/Cairo
> +       "Egypt Standard Time":             {"EET", "EET"},    //
> Africa/Cairo
>         "Morocco Standard Time":           {"WET", "WEST"},   //
> Africa/Casablanca
>         "South Africa Standard Time":      {"SAST", "SAST"},  //
> Africa/Johannesburg
>         "W. Central Africa Standard Time": {"WAT", "WAT"},    //
> Africa/Lagos
> @@ -22,7 +22,7 @@
>         "Namibia Standard Time":           {"WAT", "WAST"},   //
> Africa/Windhoek
>         "Alaskan Standard Time":           {"AKST", "AKDT"},  //
> America/Anchorage
>         "Paraguay Standard Time":          {"PYT", "PYST"},   //
> America/Asuncion
> -       "Bahia Standard Time":             {"BRT", "BRT"},    //
> America/Bahia
> +       "Bahia Standard Time":             {"BRT", "BRST"},   //
> America/Bahia
>         "SA Pacific Standard Time":        {"COT", "COT"},    //
> America/Bogota
>         "Argentina Standard Time":         {"ART", "ART"},    //
> America/Buenos_Aires
>         "Venezuela Standard Time":         {"VET", "VET"},    //
> America/Caracas
> @@ -105,9 +105,9 @@
>         "Romance Standard Time":          {"CET", "CEST"},      //
> Europe/Paris
>         "Central European Standard Time": {"CET", "CEST"},      //
> Europe/Warsaw
>         "Mauritius Standard Time":        {"MUT", "MUT"},       //
> Indian/Mauritius
> -       "Samoa Standard Time":            {"WST", "WSDT"},      //
> Pacific/Apia
> +       "Samoa Standard Time":            {"WST", "WST"},       //
> Pacific/Apia
>         "New Zealand Standard Time":      {"NZST", "NZDT"},     //
> Pacific/Auckland
> -       "Fiji Standard Time":             {"FJT", "FJST"},      //
> Pacific/Fiji
> +       "Fiji Standard Time":             {"FJT", "FJT"},       //
> Pacific/Fiji
>         "Central Pacific Standard Time":  {"SBT", "SBT"},       //
> Pacific/Guadalcanal
>         "Hawaiian Standard Time":         {"HST", "HST"},       //
> Pacific/Honolulu
>         "Line Islands Standard Time":     {"LINT", "LINT"},     //
> Pacific/Kiritimati
>
> Is it possible that you download different file from me?
>
> Alex
>
> https://codereview.appspot.com/128350044/

[brainman, 2014-09-01 02:53:14]

On 2014/08/27 03:57:27, r wrote:
> I ran it and that's what happened. If you'd rather revert or update it
> differently, feel free.
> 

Here https://codereview.appspot.com/140780043/ is my change.

Alex