LGTM On Aug 20, 2014 12:15 PM, <josharian@gmail.com> wrote: > Reviewers: golang-codereviews, > > Message: ...
10 years, 6 months ago
(2014-08-20 21:35:27 UTC)
#2
LGTM
On Aug 20, 2014 12:15 PM, <josharian@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> runtime: remove unused variable
>
>
> Please review this at https://codereview.appspot.com/128230047/
>
> Affected files (+1, -1 lines):
> M src/pkg/runtime/atomic_arm.c
>
>
> Index: src/pkg/runtime/atomic_arm.c
> ===================================================================
> --- a/src/pkg/runtime/atomic_arm.c
> +++ b/src/pkg/runtime/atomic_arm.c
> @@ -172,7 +172,7 @@
> void
> runtime·atomicor8(byte volatile *addr, byte v)
> {
> - uint32 *addr32, old, word, shift;
> + uint32 *addr32, old, word;
>
> // Align down to 4 bytes and use 32-bit CAS.
> addr32 = (uint32*)((uintptr)addr & ~3);
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 128230047: code review 128230047: runtime: remove unused variable
(Closed)
Created 10 years, 6 months ago by josharian
Modified 10 years, 6 months ago
Reviewers: gobot
Base URL:
Comments: 0