code review 128230045: cmd/gc: fix heap buffer overflow

cmd/gc: fix heap buffer overflow
Fixes issue 8528.

[dvyukov, 2014-08-14 12:26:32]

Hello rsc@golang.org, r@golang.org, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[rsc, 2014-08-19 00:48:47]

LGTM

[bradfitz, 2014-08-19 00:57:20]

Does this need to be applied to the Go 1.3 branch?



On Mon, Aug 18, 2014 at 5:48 PM, <rsc@golang.org> wrote:

> LGTM
>
>
> https://codereview.appspot.com/128230045/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-08-19 00:58:30]

Eventually. It is not worth cutting a release unless someone runs into this
for real.
It's only a stray read. As long as the read does not hit unmapped memory
and crash, the execution will be correct.

[dvyukov, 2014-08-19 07:49:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=e34ca40b4857 ***

cmd/gc: fix heap buffer overflow
Fixes issue 8528.

LGTM=rsc
R=rsc, r, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/128230045