Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(878)

Issue 128130043: code review 128130043: [release-branch.go1.3] undo 941ef9ddbada / 125150044 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by adg
Modified:
9 years, 7 months ago
Reviewers:
r, rsc
CC:
r, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] undo 941ef9ddbada / 125150044 It broke the build across all platforms. The original change wasn't even reviewed. Probably should never have been ported to this branch.

Patch Set 1 #

Patch Set 2 : diff -r 941ef9ddbada2b353b971f6b2e6d93e6306a08a5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M src/pkg/runtime/mgc0.c View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4
adg
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-08-13 03:37:19 UTC) #1
r
LGTM
9 years, 7 months ago (2014-08-13 03:37:56 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=1a58c0ea234f *** [release-branch.go1.3] undo 941ef9ddbada / 125150044 It broke the build across ...
9 years, 7 months ago (2014-08-13 03:38:59 UTC) #3
rsc
9 years, 7 months ago (2014-08-13 03:42:07 UTC) #4
Message was sent while issue was closed.
FWIW the original change was reviewed. It's in the mailing list archive, just
not on codereview due to mail loss during that time. But I'm still glad it is
rolled back now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b