Issue 12812044: code review 12812044: test: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12812044: code review 12812044: test: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
adg

CC:
golang-dev

Visibility:
Public.

Description

test: fix build syntax/*: update messages sliceerr3.go: bizarre new error fixed by deleting a space. I could have sworn I ran all.bash before submitting the CL that triggered these. TBR=golang-dev@googlegroups.com

Patch Set 1 #

Patch Set 2 : diff -r a503fae0e05a https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	test/slice3err.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi1.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi2.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi3.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi4.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-08-19 02:04:15 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=9fb09f7edb82 *** test: fix build syntax/*: update messages sliceerr3.go: bizarre new error ...

11 years, 7 months ago (2013-08-19 02:05:42 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages