Issue 127950044: code review 127950044: [release-branch.go1.3] runtime: turn off 'unexpected re...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 127950044: code review 127950044: [release-branch.go1.3] runtime: turn off 'unexpected re... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by adg

Modified:
9 years, 8 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] runtime: turn off 'unexpected return pc' print on arm traceback ««« CL 118670043 / 671fa8a9eb80 runtime: turn off 'unexpected return pc' print on arm traceback It can happen legitimately if a profiling signal arrives at just the wrong moment. It's harmless. Fixes issue 8153. LGTM=minux R=golang-codereviews, minux CC=golang-codereviews, iant, r https://codereview.appspot.com/118670043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 58ee390ff31602edb66af41ed10901ec95904d33 https://code.google.com/p/go #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/pkg/runtime/traceback_arm.c	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 8 months ago (2014-08-11 23:46:34 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=1ebf7615d3a7 *** [release-branch.go1.3] runtime: turn off 'unexpected return pc' print on arm ...

9 years, 8 months ago (2014-08-11 23:46:52 UTC) #2

LGTM

Expand All Messages | Collapse All Messages