code review 127950043: compiler: comma-ok assignments produce untyped bool as ...

cmd/gc: comma-ok assignments produce untyped bool as 2nd result

[cmang, 2014-08-11 22:40:27]

Hello gri@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-08-11 22:48:59]

change prefix to "cmd/gc" not compiler

[cmang, 2014-08-11 22:51:25]

On 2014/08/11 22:48:59, rsc wrote:
> change prefix to "cmd/gc" not compiler

Fixed

[rsc, 2014-08-11 22:59:32]

LGTM

Thanks.

[cmang, 2014-08-11 23:11:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a2621a2e43b ***

cmd/gc: comma-ok assignments produce untyped bool as 2nd result

LGTM=rsc
R=gri, rsc
CC=golang-codereviews
https://codereview.appspot.com/127950043

[gobot, 2014-08-11 23:38:03]

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/e522dcefeddcb1db5f647f6e3c5f6cb039b04fb4

[iant, 2014-08-11 23:41:15]

On Mon, Aug 11, 2014 at 4:38 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the windows-386 builder.
> See http://build.golang.org/log/e522dcefeddcb1db5f647f6e3c5f6cb039b04fb4
>
>
> https://codereview.appspot.com/127950043/

Nope.

--- FAIL: TestConnICMPEcho (0.27s)
ipraw_test.go:133: Conn.Read failed: WSARecv ip4 127.0.0.1: i/o timeout
FAIL
FAIL net 18.905s