code review 12773044: math: convert textflags from numbers to symbols

math: convert textflags from numbers to symbols

[khr, 2013-08-12 16:33:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[bradfitz, 2013-08-12 16:38:25]

LGTM



On Mon, Aug 12, 2013 at 9:33 AM, <khr@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> math: convert textflags from numbers to symbols
>
> Please review this at
https://codereview.appspot.**com/12773044/<https://codereview.appspot.com/127...
>
> Affected files:
>   M src/pkg/math/abs_386.s
>   M src/pkg/math/abs_amd64.s
>   M src/pkg/math/abs_arm.s
>   M src/pkg/math/asin_386.s
>   M src/pkg/math/asin_amd64.s
>   M src/pkg/math/asin_arm.s
>   M src/pkg/math/atan2_386.s
>   M src/pkg/math/atan2_amd64.s
>   M src/pkg/math/atan2_arm.s
>   M src/pkg/math/atan_386.s
>   M src/pkg/math/atan_amd64.s
>   M src/pkg/math/atan_arm.s
>   M src/pkg/math/dim_386.s
>   M src/pkg/math/dim_amd64.s
>   M src/pkg/math/dim_arm.s
>   M src/pkg/math/exp2_386.s
>   M src/pkg/math/exp2_amd64.s
>   M src/pkg/math/exp2_arm.s
>   M src/pkg/math/exp_386.s
>   M src/pkg/math/exp_amd64.s
>   M src/pkg/math/exp_arm.s
>   M src/pkg/math/expm1_386.s
>   M src/pkg/math/expm1_amd64.s
>   M src/pkg/math/expm1_arm.s
>   M src/pkg/math/floor_386.s
>   M src/pkg/math/floor_amd64.s
>   M src/pkg/math/floor_arm.s
>   M src/pkg/math/fltasm_amd64.s
>   M src/pkg/math/frexp_386.s
>   M src/pkg/math/frexp_amd64.s
>   M src/pkg/math/frexp_arm.s
>   M src/pkg/math/hypot_386.s
>   M src/pkg/math/hypot_amd64.s
>   M src/pkg/math/hypot_arm.s
>   M src/pkg/math/ldexp_386.s
>   M src/pkg/math/ldexp_amd64.s
>   M src/pkg/math/ldexp_arm.s
>   M src/pkg/math/log10_386.s
>   M src/pkg/math/log10_amd64.s
>   M src/pkg/math/log10_arm.s
>   M src/pkg/math/log1p_386.s
>   M src/pkg/math/log1p_amd64.s
>   M src/pkg/math/log1p_arm.s
>   M src/pkg/math/log_386.s
>   M src/pkg/math/log_amd64.s
>   M src/pkg/math/log_arm.s
>   M src/pkg/math/mod_386.s
>   M src/pkg/math/mod_amd64.s
>   M src/pkg/math/mod_arm.s
>   M src/pkg/math/modf_386.s
>   M src/pkg/math/modf_amd64.s
>   M src/pkg/math/modf_arm.s
>   M src/pkg/math/remainder_386.s
>   M src/pkg/math/remainder_amd64.s
>   M src/pkg/math/remainder_arm.s
>   M src/pkg/math/sin_386.s
>   M src/pkg/math/sin_amd64.s
>   M src/pkg/math/sin_arm.s
>   M src/pkg/math/sincos_386.s
>   M src/pkg/math/sincos_amd64.s
>   M src/pkg/math/sincos_arm.s
>   M src/pkg/math/sqrt_386.s
>   M src/pkg/math/sqrt_amd64.s
>   M src/pkg/math/sqrt_arm.s
>   M src/pkg/math/tan_386.s
>   M src/pkg/math/tan_amd64.s
>   M src/pkg/math/tan_arm.s
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[khr, 2013-08-12 17:25:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=754f36b31d2d ***

math: convert textflags from numbers to symbols

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12773044