Issue 12763044: code review 12763044: net: make Dial, Listen and ListenPacket return consiste...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12763044: code review 12763044: net: make Dial, Listen and ListenPacket return consiste... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by mikio

Modified:
10 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: make Dial, Listen and ListenPacket return consistent error value Update issue 4856

Patch Set 1 #

Patch Set 2 : diff -r bfc402b61fc1 https://code.google.com/p/go #

Patch Set 3 : diff -r bfc402b61fc1 https://code.google.com/p/go #

Patch Set 4 : diff -r bfc402b61fc1 https://code.google.com/p/go #

Patch Set 5 : diff -r 478fdd871e70 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
M	src/pkg/net/dial.go	View	1	6 chunks	+10 lines, -8 lines	0 comments	Download
M	src/pkg/net/dial_gen.go	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/fd_unix.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/fd_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2013-08-13 07:25:04 UTC) #1

mikio

10 years, 8 months ago (2013-08-13 22:04:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2a9dbe01d897 ***

net: make Dial, Listen and ListenPacket return consistent error value

Update issue 4856

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12763044

Expand All Messages | Collapse All Messages