Issue 127440043: code review 127440043: cmd/ld: fix undefined behaviour in pcln.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 127440043: code review 127440043: cmd/ld: fix undefined behaviour in pcln.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dave

Modified:
10 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

cmd/ld: fix undefined behaviour in pcln.c Update issue 8527 Fixes, src/cmd/6l/../ld/pcln.c:93:18: runtime error: left shift of negative value -2

Patch Set 1 #

Patch Set 2 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 3 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 4 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 5 : diff -r 1991f0eb1bb4fa59d6d9ed8835d892bd2c340430 https://code.google.com/p/go #

Patch Set 6 : diff -r 16bc5182facfac06edf06eb768ff7bd4be4f4967 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/ld/pcln.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2014-08-19 03:33:58 UTC) #1

dave_cheney.net

10 years, 6 months ago (2014-08-21 23:10:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=19c11dcab770 ***

cmd/ld: fix undefined behaviour in pcln.c

Update issue 8527

Fixes, src/cmd/6l/../ld/pcln.c:93:18: runtime error: left shift of negative
value -2

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/127440043

Expand All Messages | Collapse All Messages