Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1183)

Issue 12741045: code review 12741045: go-tour: add slide about sandbox environment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
r, kortschak
CC:
golang-dev, r
Visibility:
Public.

Description

go-tour: add slide about sandbox environment Also mention rand.Seed. Fixes issue 108.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r c989ba847a22 https://code.google.com/p/go-tour #

Total comments: 1

Patch Set 3 : diff -r c989ba847a22 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M tour.article View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
10 years, 9 months ago (2013-08-14 21:13:43 UTC) #1
r
https://codereview.appspot.com/12741045/diff/1/tour.article File tour.article (right): https://codereview.appspot.com/12741045/diff/1/tour.article#newcode69 tour.article:69: #appengine: (To see a different number, seed the number ...
10 years, 9 months ago (2013-08-14 21:17:01 UTC) #2
adg
On 2013/08/14 21:17:01, r wrote: > https://codereview.appspot.com/12741045/diff/1/tour.article > File tour.article (right): > > https://codereview.appspot.com/12741045/diff/1/tour.article#newcode69 > ...
10 years, 9 months ago (2013-08-15 03:16:09 UTC) #3
r
it does make it unhelpful, though
10 years, 9 months ago (2013-08-15 03:17:32 UTC) #4
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 9 months ago (2013-08-15 03:41:08 UTC) #5
r
LGTM https://codereview.appspot.com/12741045/diff/8001/tour.article File tour.article (right): https://codereview.appspot.com/12741045/diff/8001/tour.article#newcode87 tour.article:87: #appengine: (To see a different number, seed the ...
10 years, 9 months ago (2013-08-15 04:06:23 UTC) #6
adg
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=3f353c59248f *** go-tour: add slide about sandbox environment Also mention rand.Seed. Fixes ...
10 years, 9 months ago (2013-08-15 04:10:56 UTC) #7
kortschak
NOT LGTM prog/sandbox.go does not exist. On 2013/08/15 04:10:56, adg wrote: > *** Submitted as ...
10 years, 9 months ago (2013-08-15 05:08:36 UTC) #8
adg
10 years, 9 months ago (2013-08-15 05:10:01 UTC) #9
Ah, sorry: https://codereview.appspot.com/12976043


On 15 August 2013 15:08, <dan.kortschak@adelaide.edu.au> wrote:

> NOT LGTM
>
> prog/sandbox.go does not exist.
>
>
> On 2013/08/15 04:10:56, adg wrote:
>
>> *** Submitted as
>>
>
https://code.google.com/p/go-**tour/source/detail?r=**3f353c59248f<https://co...
>
>> ***
>>
>
>  go-tour: add slide about sandbox environment
>>
>
>  Also mention rand.Seed.
>>
>
>  Fixes issue 108.
>>
>
>  R=golang-dev, r
>> CC=golang-dev
>>
https://codereview.appspot.**com/12741045<https://codereview.appspot.com/1274...
>>
>
>
>
>
https://codereview.appspot.**com/12741045/<https://codereview.appspot.com/127...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b