code review 12708043: net: fix LookupSRV ordering on plan 9

net: fix LookupSRV ordering on plan 9

lookup_plan9.go's lookupSRV is using the wrong order for srv results. order should be weight, priority, port, following the response from /net/dns:

  chi Aug  9 20:31:13 Rread tag 20 count 61 '_xmpp-client._tcp.offblast.org srv 5 0 5222 iota.offblast.org' 72

[mischief, 2013-08-09 20:53:33]

Hello golang-dev@googlegroups.com (cc: ality@pbrane.org,
golang-dev@googlegroups.com, r@google.com, rsc@google.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-09 21:16:04]

LGTM



On Fri, Aug 9, 2013 at 1:53 PM, <mischief@offblast.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: ality@pbrane.org,
> golang-dev@googlegroups.com, r@google.com, rsc@google.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net: fix LookupSRV ordering on plan 9
>
> lookup_plan9.go's lookupSRV is using the wrong order for srv results.
> order should be weight, priority, port, following the response from
> /net/dns:
>
>   chi Aug  9 20:31:13 Rread tag 20 count 61
> '_xmpp-client._tcp.offblast.**org <http://tcp.offblast.org> srv 5 0 5222
> iota.offblast.org' 72
>
> Please review this at
https://codereview.appspot.**com/12708043/<https://codereview.appspot.com/127...
>
> Affected files:
>   M src/pkg/net/lookup_plan9.go
>
>
> Index: src/pkg/net/lookup_plan9.go
> ==============================**==============================**=======
> --- a/src/pkg/net/lookup_plan9.go
> +++ b/src/pkg/net/lookup_plan9.go
> @@ -186,9 +186,9 @@
>                 if len(f) < 6 {
>                         continue
>                 }
> -               port, _, portOk := dtoi(f[2], 0)
> +               port, _, portOk := dtoi(f[4], 0)
>                 priority, _, priorityOk := dtoi(f[3], 0)
> -               weight, _, weightOk := dtoi(f[4], 0)
> +               weight, _, weightOk := dtoi(f[2], 0)
>                 if !(portOk && priorityOk && weightOk) {
>                         continue
>                 }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[bradfitz, 2013-08-09 21:16:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=d207f87da18a ***

net: fix LookupSRV ordering on plan 9

lookup_plan9.go's lookupSRV is using the wrong order for srv results. order
should be weight, priority, port, following the response from /net/dns:

  chi Aug  9 20:31:13 Rread tag 20 count 61 '_xmpp-client._tcp.offblast.org srv
5 0 5222 iota.offblast.org' 72

R=golang-dev, bradfitz
CC=ality, golang-dev, r, rsc
https://codereview.appspot.com/12708043

Committer: Brad Fitzpatrick <bradfitz@golang.org>