Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 12708043: code review 12708043: net: fix LookupSRV ordering on plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by mischief
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz, ality, r2, rsc1
Visibility:
Public.

Description

net: fix LookupSRV ordering on plan 9 lookup_plan9.go's lookupSRV is using the wrong order for srv results. order should be weight, priority, port, following the response from /net/dns: chi Aug 9 20:31:13 Rread tag 20 count 61 '_xmpp-client._tcp.offblast.org srv 5 0 5222 iota.offblast.org' 72

Patch Set 1 #

Patch Set 2 : code review 12708043: net: fix LookupSRV ordering on plan 9 #

Patch Set 3 : diff -r 4fb48ae1b069 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4fb48ae1b069 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/net/lookup_plan9.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mischief
Hello golang-dev@googlegroups.com (cc: ality@pbrane.org, golang-dev@googlegroups.com, r@google.com, rsc@google.com), I'd like you to review this change to ...
11 years, 7 months ago (2013-08-09 20:53:33 UTC) #1
bradfitz
LGTM On Fri, Aug 9, 2013 at 1:53 PM, <mischief@offblast.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 7 months ago (2013-08-09 21:16:04 UTC) #2
bradfitz
11 years, 7 months ago (2013-08-09 21:16:46 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d207f87da18a ***

net: fix LookupSRV ordering on plan 9

lookup_plan9.go's lookupSRV is using the wrong order for srv results. order
should be weight, priority, port, following the response from /net/dns:

  chi Aug  9 20:31:13 Rread tag 20 count 61 '_xmpp-client._tcp.offblast.org srv
5 0 5222 iota.offblast.org' 72

R=golang-dev, bradfitz
CC=ality, golang-dev, r, rsc
https://codereview.appspot.com/12708043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b