Issue 12703044: code review 12703044: go/build: add AllTags to Package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12703044: code review 12703044: go/build: add AllTags to Package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

go/build: add AllTags to Package AllTags lists all the tags that can affect the decision about which files to include. Tools scanning packages can use this to decide how many variants there are and what they are.

Patch Set 1 #

Patch Set 2 : diff -r 4fb48ae1b069 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 94e37af95560 https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -42 lines)			Patch
M	src/pkg/go/build/build.go	View	1	13 chunks	+44 lines, -22 lines	0 comments	Download
M	src/pkg/go/build/build_test.go	View	1	3 chunks	+44 lines, -19 lines	0 comments	Download
M	src/pkg/go/build/syslist_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2013-08-09 21:26:40 UTC) #1

rsc

10 years, 8 months ago (2013-08-09 22:34:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6eaeab5759f0 ***

go/build: add AllTags to Package

AllTags lists all the tags that can affect the decision
about which files to include. Tools scanning packages
can use this to decide how many variants there are
and what they are.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/12703044

Expand All Messages | Collapse All Messages