Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(372)

Issue 12699045: code review 12699045: runtime: fix openbsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dvyukov
Modified:
11 years, 7 months ago
Reviewers:
iant, bradfitz
CC:
golang-dev, bradfitz, iant
Visibility:
Public.

Description

runtime: fix netbsd build I've placed net.runtime_Semacquire into netpoll.goc, but netbsd does not yet use netpoll.goc.

Patch Set 1 #

Patch Set 2 : diff -r 7afd81b7fe12 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7afd81b7fe12 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7afd81b7fe12 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/pkg/runtime/netpoll.goc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/pkg/runtime/sema.goc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 7 months ago (2013-08-09 18:11:30 UTC) #1
bradfitz
LGTM On Aug 9, 2013 11:11 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev1, > > Message: ...
11 years, 7 months ago (2013-08-09 18:13:25 UTC) #2
iant
LGTM But now you've defeated the point of the runtime refactoring. On Fri, Aug 9, ...
11 years, 7 months ago (2013-08-09 18:13:55 UTC) #3
dvyukov
On Fri, Aug 9, 2013 at 10:13 PM, Ian Lance Taylor <iant@golang.org> wrote: > LGTM ...
11 years, 7 months ago (2013-08-09 18:16:23 UTC) #4
dvyukov
11 years, 7 months ago (2013-08-09 18:17:15 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=4961e85603a2 ***

runtime: fix netbsd build
I've placed net.runtime_Semacquire into netpoll.goc,
but netbsd does not yet use netpoll.goc.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/12699045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b