Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 126870043: code review 126870043: runtime: fix data race in stackalloc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by dvyukov
Modified:
9 years, 9 months ago
Reviewers:
khr
CC:
khr, golang-codereviews, rsc
Visibility:
Public.

Description

runtime: fix data race in stackalloc Stack shrinking happens during mark phase, and it assumes that it owns stackcache in mcache. Stack cache flushing also happens during mark phase, and it accesses stackcache's w/o any synchronization. This leads to stackcache corruption: http://goperfd.appspot.com/log/309af5571dfd7e1817259b9c9cf9bcf9b2c27610

Patch Set 1 #

Patch Set 2 : diff -r 6700bc3c932e8e488267c02c2f325e2d0e8887db https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 6700bc3c932e8e488267c02c2f325e2d0e8887db https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 6700bc3c932e8e488267c02c2f325e2d0e8887db https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 6700bc3c932e8e488267c02c2f325e2d0e8887db https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 7414af99c2bfea08f9c4f6774b858224e7c2a8fe https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/runtime/stack.c View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello khr@golang.org (cc: golang-codereviews@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 9 months ago (2014-08-08 15:27:18 UTC) #1
khr
On 2014/08/08 15:27:18, dvyukov wrote: > Hello mailto:khr@golang.org (cc: mailto:golang-codereviews@googlegroups.com, mailto:rsc@golang.org), > > I'd like ...
9 years, 9 months ago (2014-08-08 15:31:46 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=e9af2ad43c07 *** runtime: fix data race in stackalloc Stack shrinking happens during ...
9 years, 9 months ago (2014-08-08 16:14:06 UTC) #3
rsc
9 years, 9 months ago (2014-08-08 20:45:07 UTC) #4
nice, this fixed amd64p32
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b