Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 12677043: code review 12677043: cmd/gc: make missing package error fatal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rick
Modified:
11 years, 7 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/gc: make missing package error fatal No longer continue assuming package main. Fixes issue 4776.

Patch Set 1 #

Patch Set 2 : diff -r 23e06fccd3b9 https://code.google.com/p/go #

Patch Set 3 : diff -r 23e06fccd3b9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/cmd/gc/go.y View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 1 chunk +1 line, -2 lines 0 comments Download
A test/fixedbugs/issue4776.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rick
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-08-08 19:53:00 UTC) #1
r
LGTM
11 years, 7 months ago (2013-08-09 06:02:40 UTC) #2
r
11 years, 7 months ago (2013-08-09 06:06:06 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=2deb5fc5f260 ***

cmd/gc: make missing package error fatal

No longer continue assuming package main.

Fixes issue 4776.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12677043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b