Issue 12669043: code review 12669043: runtime: print scavenger details when forced with debug...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12669043: code review 12669043: runtime: print scavenger details when forced with debug... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

runtime: print scavenger details when forced with debug.FreeOSMemory Fixes issue 5900.

Patch Set 2 : diff -r 23e06fccd3b9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 23e06fccd3b9 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 29b6246f5a9c https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	src/pkg/runtime/mheap.c	View	1	5 chunks	+13 lines, -15 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-08 15:30:51 UTC) #1

bradfitz

https://codereview.appspot.com/12669043/diff/6001/src/pkg/runtime/mheap.c File src/pkg/runtime/mheap.c (right): https://codereview.appspot.com/12669043/diff/6001/src/pkg/runtime/mheap.c#newcode485 src/pkg/runtime/mheap.c:485: scavenge(k, now, limit); what is k? looks like you're ...

11 years, 7 months ago (2013-08-08 17:04:08 UTC) #2

dvyukov

11 years, 7 months ago (2013-08-08 17:16:23 UTC) #3

dvyukov

11 years, 7 months ago (2013-08-08 17:55:22 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=03b39553686a ***

runtime: print scavenger details when forced with debug.FreeOSMemory
Fixes issue 5900.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12669043

Expand All Messages | Collapse All Messages