Issue 126620043: code review 126620043: net/http: populate Request.Close in ReadRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 126620043: code review 126620043: net/http: populate Request.Close in ReadRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by bradfitz

Modified:
9 years, 8 months ago

Reviewers:
r, gobot

CC:
r, golang-codereviews

Visibility:
Public.

Description

net/http: populate Request.Close in ReadRequest Fixes Issue 8261

Patch Set 1 #

Patch Set 2 : diff -r 7b74849f8514f95f6cdaf6b4ab6653b608276506 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7b74849f8514f95f6cdaf6b4ab6653b608276506 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bc9f33c1650f35f613ebd867071187356582f08a https://go.googlecode.com/hg/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
M	src/pkg/net/http/readrequest_test.go	View	1	3 chunks	+34 lines, -7 lines	0 comments	Download
M	src/pkg/net/http/request.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/net/http/transfer.go	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 8 months ago (2014-08-25 18:38:06 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=fb649e841095 *** net/http: populate Request.Close in ReadRequest Fixes Issue 8261 LGTM=r R=r ...

9 years, 8 months ago (2014-08-25 18:44:17 UTC) #3

gobot

9 years, 8 months ago (2014-08-25 19:10:16 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-386 builder.
See http://build.golang.org/log/eee5c980679b7d7c133d45578053f04c084df901

Expand All Messages | Collapse All Messages