Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(405)

Issue 12657044: code review 12657044: net/mail: AddressList fails to parse addresses with a dot (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by ryanslade
Modified:
11 years, 2 months ago
Reviewers:
dsymonds, bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net/mail: AddressList fails to parse addresses with a dot Fixes issue 4938.

Patch Set 1 #

Patch Set 2 : diff -r 23e06fccd3b9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 23e06fccd3b9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/pkg/net/mail/message.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/mail/message_test.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ryanslade
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2013-08-08 16:31:27 UTC) #1
bradfitz
LGTM On Thu, Aug 8, 2013 at 9:31 AM, <ryanslade@gmail.com> wrote: > Reviewers: golang-dev1, > ...
11 years, 7 months ago (2013-08-08 17:00:14 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=96b8f1b578c1 *** net/mail: AddressList fails to parse addresses with a dot Fixes ...
11 years, 7 months ago (2013-08-08 17:00:28 UTC) #3
dsymonds
This isn't right. The relevant part of RFC 5322 is word = atom / quoted-string ...
11 years, 7 months ago (2013-08-08 23:55:36 UTC) #4
dsymonds
At the least there should be a comment here explaining that we are intentionally parsing ...
11 years, 7 months ago (2013-08-08 23:56:28 UTC) #5
bradfitz
11 years, 7 months ago (2013-08-09 00:02:56 UTC) #6
submitted per comments on the issue.

Feel free to add a comment.



On Thu, Aug 8, 2013 at 4:56 PM, <dsymonds@golang.org> wrote:

> At the least there should be a comment here explaining that we are
> intentionally parsing this more leniently than the RFC specifies.
>
>
https://codereview.appspot.**com/12657044/<https://codereview.appspot.com/126...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b