code review 12657044: net/mail: AddressList fails to parse addresses with a dot

net/mail: AddressList fails to parse addresses with a dot

Fixes issue 4938.

[ryanslade, 2013-08-08 16:31:27]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-08 17:00:14]

LGTM



On Thu, Aug 8, 2013 at 9:31 AM, <ryanslade@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/mail: AddressList fails to parse addresses with a dot
>
> Fixes issue 4938.
>
> Please review this at
https://codereview.appspot.**com/12657044/<https://codereview.appspot.com/126...
>
> Affected files:
>   M src/pkg/net/mail/message.go
>   M src/pkg/net/mail/message_test.**go
>
>
> Index: src/pkg/net/mail/message.go
> ==============================**==============================**=======
> --- a/src/pkg/net/mail/message.go
> +++ b/src/pkg/net/mail/message.go
> @@ -342,7 +342,7 @@
>                         word, err = p.consumeQuotedString()
>                 } else {
>                         // atom
> -                       word, err = p.consumeAtom(false)
> +                       word, err = p.consumeAtom(true)
>                 }
>
>                 // RFC 2047 encoded-word starts with =?, ends with ?=, and
> has two other ?s.
> Index: src/pkg/net/mail/message_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/net/mail/message_**test.go
> +++ b/src/pkg/net/mail/message_**test.go
> @@ -225,6 +225,16 @@
>                                 },
>                         },
>                 },
> +               // Custom example with "." in name. For issue 4938
> +               {
> +                       `Asem H. <noreply@example.com>`,
> +                       []*Address{
> +                               {
> +                                       Name:    `Asem H.`,
> +                                       Address: "noreply@example.com",
> +                               },
> +                       },
> +               },
>         }
>         for _, test := range tests {
>                 if len(test.exp) == 1 {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[bradfitz, 2013-08-08 17:00:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=96b8f1b578c1 ***

net/mail: AddressList fails to parse addresses with a dot

Fixes issue 4938.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12657044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[dsymonds, 2013-08-08 23:55:36]

This isn't right. The relevant part of RFC 5322 is
      word            =   atom / quoted-string

That is, "atom", not "dot-atom". This is an invalid address; it should be using
a quoted string.

[dsymonds, 2013-08-08 23:56:28]

At the least there should be a comment here explaining that we are intentionally
parsing this more leniently than the RFC specifies.

[bradfitz, 2013-08-09 00:02:56]

submitted per comments on the issue.

Feel free to add a comment.



On Thu, Aug 8, 2013 at 4:56 PM, <dsymonds@golang.org> wrote:

> At the least there should be a comment here explaining that we are
> intentionally parsing this more leniently than the RFC specifies.
>
>
https://codereview.appspot.**com/12657044/<https://codereview.appspot.com/126...
>