code review 12645043: regexp/syntax: make it clearer that \b and \B are ASCII...

regexp/syntax: make it clearer that \b and \B are ASCII-defined
Fixes issue 5896.

[r, 2013-08-08 03:07:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-08 03:10:50]

LGTM
 On Aug 7, 2013 8:07 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> regexp/syntax: make it clearer that \b and \B are ASCII-defined
> Fixes issue 5896.
>
> Please review this at
https://codereview.appspot.**com/12645043/<https://codereview.appspot.com/126...
>
> Affected files:
>   M src/pkg/regexp/syntax/doc.go
>
>
> Index: src/pkg/regexp/syntax/doc.go
> ==============================**==============================**=======
> --- a/src/pkg/regexp/syntax/doc.go
> +++ b/src/pkg/regexp/syntax/doc.go
> @@ -64,8 +64,8 @@
>    ^              at beginning of text or line (flag m=true)
>    $              at end of text (like \z not \Z) or line (flag m=true)
>    \A             at beginning of text
> -  \b             at word boundary (\w on one side and \W, \A, or \z on
> the other)
> -  \B             not a word boundary
> +  \b             at ASCII word boundary (\w on one side and \W, \A, or \z
> on the other)
> +  \B             not an ASCII word boundary
>    \z             at end of text
>
>  Escape sequences:
> @@ -104,8 +104,8 @@
>    \D             not digits (== [^0-9])
>    \s             whitespace (== [\t\n\f\r ])
>    \S             not whitespace (== [^\t\n\f\r ])
> -  \w             word characters (== [0-9A-Za-z_])
> -  \W             not word characters (== [^0-9A-Za-z_])
> +  \w             ASCII word characters (== [0-9A-Za-z_])
> +  \W             not ASCII word characters (== [^0-9A-Za-z_])
>
>  ASCII character classes:
>    [:alnum:]      alphanumeric (== [0-9A-Za-z])
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-08-08 03:26:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=2a74ed09bf00 ***

regexp/syntax: make it clearer that \b and \B are ASCII-defined
Fixes issue 5896.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12645043