Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
LGTM On Wed, Aug 7, 2013 at 11:28 AM, <iant@golang.org> wrote: > Reviewers: golang-dev1, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > test: add cases to return.go that gccgo got wrong > > Please review this at https://codereview.appspot.**com/12620043/<https://codereview.appspot.com/126... > > Affected files: > M test/return.go > > > Index: test/return.go > ==============================**==============================**======= > --- a/test/return.go > +++ b/test/return.go > @@ -1406,6 +1406,16 @@ > } > } // ERROR "missing return" > > +func _() int { > + switch x.(type) { > + default: > + return 4 > + case int, float64: > + print(2) > + panic(3) > + } > +} > + > // again, with func literals > > var _ = func() int { > @@ -2798,4 +2808,14 @@ > } > } // ERROR "missing return" > > +var _ = func() int { > + switch x.(type) { > + default: > + return 4 > + case int, float64: > + print(2) > + panic(3) > + } > +} > + > /**/ > > > -- > > ---You received this message because you are subscribed to the Google > Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou... > . > For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o... > . > > >
*** Submitted as https://code.google.com/p/go/source/detail?r=619bcb1a0254 *** test: add cases to return.go that gccgo got wrong R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/12620043