Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 12614043: code review 12614043: test: fix return.go to not use fallthrough in a type switch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by iant
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

test: fix return.go to not use fallthrough in a type switch The gc compiler only gives an error about fallthrough in a type switch if it has not given any errors in an earlier pass. Remove all functions in this test that use fallthrough in a type switch because they don't test anything useful and they cause gccgo to give unexpected errors.

Patch Set 1 #

Patch Set 2 : diff -r cfc3eab6195a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M test/return.go View 8 chunks +0 lines, -84 lines 0 comments Download

Messages

Total messages: 3
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-08-07 17:11:07 UTC) #1
bradfitz
LGTM On Wed, Aug 7, 2013 at 10:11 AM, <iant@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 7 months ago (2013-08-07 18:01:47 UTC) #2
iant
11 years, 7 months ago (2013-08-07 18:05:27 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=8febfb2350b4 ***

test: fix return.go to not use fallthrough in a type switch

The gc compiler only gives an error about fallthrough in a
type switch if it has not given any errors in an earlier pass.
Remove all functions in this test that use fallthrough in a
type switch because they don't test anything useful and they
cause gccgo to give unexpected errors.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12614043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b