code review 126010043: [release-branch.go1.3] runtime: ignore exceptions from ...

[release-branch.go1.3] runtime: ignore exceptions from foreign threads.

««« CL 104200046 / 14683b1cf2cc
runtime: ignore exceptions from foreign threads.
Fixes issue 8224.

LGTM=alex.brainman, rsc
R=alex.brainman, rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/104200046
»»»

[adg, 2014-08-12 00:10:17]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2014-08-12 00:12:18]

Please review this carefully as I had to manually apply the patch
(release-apply with --ignore_hgapplydiff_failure and then manual merge).

Thanks.

[brainman, 2014-08-12 00:57:17]

How would I apply your patch to try it?

Alex

[adg, 2014-08-12 01:28:33]

hg update release-branch.go1.3
hg clpatch 126010043

On Tuesday, 12 August 2014, <alex.brainman@gmail.com> wrote:

> How would I apply your patch to try it?
>
> Alex
>
> https://codereview.appspot.com/126010043/
>

[brainman, 2014-08-12 03:17:27]

On 2014/08/12 01:28:33, adg wrote:
> hg update release-branch.go1.3
> hg clpatch 126010043
> 

I tried it:

# hg update release-branch.go1.3
621 files updated, 0 files merged, 133 files removed, 0 files unresolved
# hg clpatch 126010043
abort: cannot run hg clpatch outside default branch

but no good.

Alex

[adg, 2014-08-12 03:22:27]

I have confirmed that the patch looks good, but since I applied the patch
manually I want a second pair of eyes to check the patch matches the
original.

Actually testing it functionally isn't necessary.

On Tuesday, 12 August 2014, <alex.brainman@gmail.com> wrote:

> On 2014/08/12 01:28:33, adg wrote:
>
>> hg update release-branch.go1.3
>> hg clpatch 126010043
>>
>
>
> I tried it:
>
> # hg update release-branch.go1.3
> 621 files updated, 0 files merged, 133 files removed, 0 files unresolved
> # hg clpatch 126010043
> abort: cannot run hg clpatch outside default branch
>
> but no good.
>
> Alex
>
> https://codereview.appspot.com/126010043/
>

[brainman, 2014-08-12 03:29:04]

LGTM

[minux, 2014-08-12 03:37:08]

LGTM.

[adg, 2014-08-12 04:07:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=17d80550d371 ***

[release-branch.go1.3] runtime: ignore exceptions from foreign threads.

««« CL 104200046 / 14683b1cf2cc
runtime: ignore exceptions from foreign threads.
Fixes issue 8224.

LGTM=alex.brainman, rsc
R=alex.brainman, rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/104200046
»»»

LGTM=alex.brainman, minux
R=rsc, alex.brainman, minux
CC=golang-codereviews
https://codereview.appspot.com/126010043