code review 126000043: [release-branch.go1.3] cmd/6g, cmd/8g: fix, test byte-s...

[release-branch.go1.3] cmd/6g, cmd/8g: fix, test byte-sized magic multiply

««« CL 124950043 / 8e5ec6948793
cmd/6g, cmd/8g: fix, test byte-sized magic multiply

Credit to Rémy for finding and writing test case.

Fixes issue 8325.

LGTM=r
R=golang-codereviews, r
CC=dave, golang-codereviews, iant, remyoudompheng
https://codereview.appspot.com/124950043
»»»

[adg, 2014-08-12 00:05:12]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2014-08-12 00:05:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=8246129e698d ***

[release-branch.go1.3] cmd/6g, cmd/8g: fix, test byte-sized magic multiply

««« CL 124950043 / 8e5ec6948793
cmd/6g, cmd/8g: fix, test byte-sized magic multiply

Credit to Rémy for finding and writing test case.

Fixes issue 8325.

LGTM=r
R=golang-codereviews, r
CC=dave, golang-codereviews, iant, remyoudompheng
https://codereview.appspot.com/124950043
»»»

TBR=rsc
CC=golang-codereviews
https://codereview.appspot.com/126000043

[rsc, 2014-08-12 00:06:38]

LGTM
be sure to get the 8g fix too

[adg, 2014-08-12 00:11:25]

Doesn't this include the 8g fix?


On 12 August 2014 10:06, Russ Cox <rsc@golang.org> wrote:

> LGTM
> be sure to get the 8g fix too
>
>

[minux, 2014-08-12 00:16:38]

On Mon, Aug 11, 2014 at 8:10 PM, Andrew Gerrand <adg@golang.org> wrote:

> Doesn't this include the 8g fix?
>
it's in https://codereview.appspot.com/129720043/ and issue 8510.

[gobot, 2014-08-12 00:19:32]

This CL appears to have broken the freebsd-386 builder.
See http://build.golang.org/log/6e1f330988ab1462ac6afbdd77a0a55853d0fb35