Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 12583046: code review 12583046: net: give C.getaddrinfo a hint that we only want SOCK_S... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by iant
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: give C.getaddrinfo a hint that we only want SOCK_STREAM answers This should be more efficient everywhere, and appears to be required on Solaris.

Patch Set 1 #

Patch Set 2 : diff -r cef777ff3066 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/net/cgo_unix.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-08-09 13:38:43 UTC) #1
bradfitz
LGTM
11 years, 7 months ago (2013-08-09 15:58:57 UTC) #2
iant
11 years, 7 months ago (2013-08-09 16:23:30 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=07295f40fe71 ***

net: give C.getaddrinfo a hint that we only want SOCK_STREAM answers

This should be more efficient everywhere, and appears to be
required on Solaris.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12583046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b