Issue 1258042: code review 1258042: big: potential bug fix, cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1258042: code review 1258042: big: potential bug fix, cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by gri

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

big: potential bug fix, cleanups - implemented setWord, use it where setUint64 is wrong - divLarge: use fast mulWW, divWW; implemented mulWW, divWW - better assembly code for addMulVVW

Patch Set 2 : code review 1258042: big: potential bug fix, cleanups #

Total comments: 1

Patch Set 3 : code review 1258042: big: potential bug fix, cleanups #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -19 lines)			Patch
M	src/pkg/big/arith.go	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/big/arith_386.s	View	1 2	2 chunks	+21 lines, -3 lines	0 comments	Download
M	src/pkg/big/arith_amd64.s	View	1 2	2 chunks	+21 lines, -3 lines	0 comments	Download
M	src/pkg/big/nat.go	View	1 2	5 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-05-19 01:18:00 UTC) #1

rsc

LGTM http://codereview.appspot.com/1258042/diff/2001/3004 File src/pkg/big/nat.go (right): http://codereview.appspot.com/1258042/diff/2001/3004#newcode84 src/pkg/big/nat.go:84: w := Word(x) maybe move into if to ...

14 years, 10 months ago (2010-05-19 05:59:25 UTC) #2

gri

14 years, 10 months ago (2010-05-19 16:36:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2d5c6bd9bca8 ***

big: potential bug fix, cleanups

- implemented setWord, use it where setUint64 is wrong
- divLarge: use fast mulWW, divWW; implemented mulWW, divWW
- better assembly code for addMulVVW

R=rsc
CC=golang-dev
http://codereview.appspot.com/1258042

Expand All Messages | Collapse All Messages