code review 12548043: runtime/pprof: adjust test

runtime/pprof: adjust test

NetBSD and OpenBSD are broken like OS X is. Good to know.

Drop required count from avg/2 to avg/3, because the
Plan 9 builder just barely missed avg/2 in one of its runs.

[rsc, 2013-08-06 17:16:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dvyukov, 2013-08-06 17:33:34]

LGTM

On Tue, Aug 6, 2013 at 9:16 PM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime/pprof: adjust test
>
> NetBSD and OpenBSD are broken like OS X is. Good to know.
>
> Drop required count from avg/2 to avg/3, because the
> Plan 9 builder just barely missed avg/2 in one of its runs.
>
> Please review this at https://codereview.appspot.com/12548043/
>
> Affected files:
>   M src/pkg/runtime/pprof/pprof.go
>   M src/pkg/runtime/pprof/pprof_test.go
>
>
> Index: src/pkg/runtime/pprof/pprof.go
> ===================================================================
> --- a/src/pkg/runtime/pprof/pprof.go
> +++ b/src/pkg/runtime/pprof/pprof.go
> @@ -20,7 +20,8 @@
>         "text/tabwriter"
>  )
>
> -// BUG(rsc): Profiles are incomplete and inaccuate on OS X. See
> http://golang.org/issue/6047 for details.
> +// BUG(rsc): Profiles are incomplete and inaccuate on NetBSD, OpenBSD, and
> OS X.
> +// See http://golang.org/issue/6047 for details.
>
>  // A Profile is a collection of stack traces showing the call sequences
>  // that led to instances of a particular event, such as allocation.
> Index: src/pkg/runtime/pprof/pprof_test.go
> ===================================================================
> --- a/src/pkg/runtime/pprof/pprof_test.go
> +++ b/src/pkg/runtime/pprof/pprof_test.go
> @@ -78,11 +78,12 @@
>         val = val[:l]
>
>         if l < 13 {
> -               if runtime.GOOS == "darwin" {
> -                       t.Logf("ignoring failure on OS X; see
> golang.org/issue/6047")
> +               t.Logf("profile too short: %#x", val)
> +               if badOS[runtime.GOOS] {
> +                       t.Skipf("ignoring failure on %s; see
> golang.org/issue/6047", runtime.GOOS)
>                         return
>                 }
> -               t.Fatalf("profile too short: %#x", val)
> +               t.FailNow()
>         }
>
>         hd, val, tl := val[:5], val[5:l-3], val[l-3:]
> @@ -124,7 +125,7 @@
>                 t.Logf("no CPU profile samples collected")
>                 ok = false
>         }
> -       min := total / uintptr(len(have)) / 2
> +       min := total / uintptr(len(have)) / 3
>         for i, name := range need {
>                 if have[i] < min {
>                         t.Logf("%s has %d samples out of %d, want at least
> %d, ideally %d", name, have[i], total, min, total/uintptr(len(have)))
> @@ -133,10 +134,17 @@
>         }
>
>         if !ok {
> -               if runtime.GOOS == "darwin" {
> -                       t.Logf("ignoring failure on OS X; see
> golang.org/issue/6047")
> +               if badOS[runtime.GOOS] {
> +                       t.Skipf("ignoring failure on %s; see
> golang.org/issue/6047", runtime.GOOS)
>                         return
>                 }
>                 t.FailNow()
>         }
>  }
> +
> +// Operating systems that are expected to fail the tests. See issue 6047.
> +var badOS = map[string]bool{
> +       "darwin":  true,
> +       "netbsd":  true,
> +       "openbsd": true,
> +}
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[rsc, 2013-08-06 18:49:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=045269edbbee ***

runtime/pprof: adjust test

NetBSD and OpenBSD are broken like OS X is. Good to know.

Drop required count from avg/2 to avg/3, because the
Plan 9 builder just barely missed avg/2 in one of its runs.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/12548043