Issue 12520043: code review 12520043: runtime: change int32 to intgo in findnull and findnullw

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12520043: code review 12520043: runtime: change int32 to intgo in findnull and findnullw (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

runtime: change int32 to intgo in findnull and findnullw Update issue 6046. This CL just does findnull and findnullw. There are other functions to fix but doing them a few at a time will help isolate any (unlikely) breakages these changes bring up in architectures I can't test myself.

Patch Set 1 #

Patch Set 2 : diff -r fbc1a650b595 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -13 lines)			Patch
M	src/pkg/runtime/env_plan9.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/env_posix.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_plan9.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_plan9_386.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/os_plan9_amd64.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/print.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/string.goc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-08-06 10:08:56 UTC) #1

11 years, 7 months ago (2013-08-06 11:49:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=50c9f3544eed ***

runtime: change int32 to intgo in findnull and findnullw

Update issue 6046.
This CL just does findnull and findnullw. There are other functions
to fix but doing them a few at a time will help isolate any (unlikely)
breakages these changes bring up in architectures I can't test
myself.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/12520043

Expand All Messages | Collapse All Messages