code review 12519044: runtime: change int32 to intgo in maxstring and concatstring

runtime: use correct types for maxstring and concatstring

Updates issue 6046.
This CL just does maxstring and concatstring. There are other functions
to fix but doing them a few at a time will help isolate any (unlikely)
breakages these changes bring up in architectures I can't test
myself.

[r, 2013-08-06 12:04:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-08-06 12:07:41]

https://codereview.appspot.com/12519044/diff/1/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

https://codereview.appspot.com/12519044/diff/1/src/pkg/runtime/runtime.h#newc...
src/pkg/runtime/runtime.h:709: extern	uint64	runtime·maxstring;
Is it possible to make this uintptr instead? Using 64bit ints on arm is slow.

[r, 2013-08-06 12:17:14]

I doubt this particular change will have much effect on ARM. In any case,
uintptr is problematic because there's a cas operation and we need to know
which one to use based on the size.

-rob

[iant, 2013-08-06 13:03:38]

On 2013/08/06 12:17:14, r wrote:
> I doubt this particular change will have much effect on ARM. In any case,
> uintptr is problematic because there's a cas operation and we need to know
> which one to use based on the size.

The runtime provides runtime·casp that can be used with a pointer-sized value.

[iant, 2013-08-06 13:07:16]

https://codereview.appspot.com/12519044/diff/6001/src/pkg/runtime/print.c
File src/pkg/runtime/print.c (right):

https://codereview.appspot.com/12519044/diff/6001/src/pkg/runtime/print.c#new...
src/pkg/runtime/print.c:353: extern uint64 runtime·maxstring;
Since maxstring is declared in runtime.h now, I think you should just remove
this extern declaration.

[r, 2013-08-06 20:42:51]

Hello golang-dev@googlegroups.com, dave@cheney.net, iant@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[iant, 2013-08-06 20:47:02]

LGTM

[r, 2013-08-06 20:49:20]

*** Submitted as https://code.google.com/p/go/source/detail?r=a1ad6d6d8ad4 ***

runtime: use correct types for maxstring and concatstring

Updates issue 6046.
This CL just does maxstring and concatstring. There are other functions
to fix but doing them a few at a time will help isolate any (unlikely)
breakages these changes bring up in architectures I can't test
myself.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/12519044