Issue 125150044: code review 125150044: [release-branch.go1.3] runtime: fix GC bitmap corruption

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 125150044: code review 125150044: [release-branch.go1.3] runtime: fix GC bitmap corruption (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by adg

Modified:
9 years, 8 months ago

Reviewers:
gobot

CC:
r, rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] runtime: fix GC bitmap corruption ««« CL 103640044 / d2f256096d8d runtime: fix GC bitmap corruption Fixes issue 8299. R=golang-codereviews CC=golang-codereviews, khr, rsc https://codereview.appspot.com/103640044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 073fc578434bf3e1e22749b559d273c8da728ebb https://code.google.com/p/go #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 8 months ago (2014-08-13 03:19:57 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=941ef9ddbada *** [release-branch.go1.3] runtime: fix GC bitmap corruption ««« CL 103640044 / ...

9 years, 8 months ago (2014-08-13 03:20:09 UTC) #2

gobot

This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/a087b026ed9bb4e24103d0a06081b3a619d2b446

9 years, 8 months ago (2014-08-13 03:29:43 UTC) #3

Roll it back. Sorry.

Expand All Messages | Collapse All Messages