Issue 12509044: code review 12509044: os: fix plan9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12509044: code review 12509044: os: fix plan9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

os: fix plan9 build I broke it with the darwin getwd attrlist stuff (0583e9d36dd). plan9 doesn't have syscall.ENOTSUP. It's in api/go1.txt as a symbol always available (not context-specific): pkg syscall, const ENOTSUP Errno ... but plan9 isn't considered by cmd/api, so it only looks universally available. Alternatively, we could add a fake ENOTSUP to plan9, but they were making efforts earlier to clean their syscall package, so I'd prefer not to dump more in it.

Patch Set 1 #

Patch Set 2 : diff -r edb46df3ae05 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r edb46df3ae05 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f9f44b2d4d79 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	src/pkg/os/getwd.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
	A	src/pkg/os/getwd_darwin.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-06 14:53:46 UTC) #1

bradfitz

11 years, 7 months ago (2013-08-06 19:04:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=da11b2a1cbc1 ***

os: fix plan9 build

I broke it with the darwin getwd attrlist stuff (0583e9d36dd).
plan9 doesn't have syscall.ENOTSUP.

It's in api/go1.txt as a symbol always available (not context-specific):

pkg syscall, const ENOTSUP Errno

... but plan9 isn't considered by cmd/api, so it only looks
universally available.  Alternatively, we could add a fake ENOTSUP
to plan9, but they were making efforts earlier to clean their
syscall package, so I'd prefer not to dump more in it.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12509044

Expand All Messages | Collapse All Messages