Issue 12508043: code review 12508043: misc/notepadplus: simplify Function List regex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12508043: code review 12508043: misc/notepadplus: simplify Function List regex (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by chai2010

Modified:
11 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

misc/notepadplus: simplify Function List regex

Patch Set 1 #

Patch Set 2 : diff -r 7500ec6996b7 http://code.google.com/p/go #

Patch Set 3 : diff -r 6294f3ca30e1 http://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
	M	misc/notepadplus/functionList.xml	View	1	1 chunk	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go

11 years, 7 months ago (2013-08-06 08:25:31 UTC) #1

bradfitz

LGTM On Tue, Aug 6, 2013 at 1:25 AM, <chaishushan@gmail.com> wrote: > Reviewers: golang-dev1, > ...

11 years, 7 months ago (2013-08-06 14:57:51 UTC) #2

LGTM



On Tue, Aug 6, 2013 at 1:25 AM, <chaishushan@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> http://code.google.com/p/go
>
>
> Description:
> misc/notepadplus: simplify Function List regex
>
> Please review this at
https://codereview.appspot.**com/12508043/<https://codereview.appspot.com/125...
>
> Affected files:
>   M misc/notepadplus/functionList.**xml
>
>
> Index: misc/notepadplus/functionList.**xml
> ==============================**==============================**=======
> --- a/misc/notepadplus/**functionList.xml
> +++ b/misc/notepadplus/**functionList.xml
> @@ -7,21 +7,16 @@
>                 <!-- <parsers> -->
>                         <parser id="go" displayName="Go"
> commentExpr="((/\*.*?\*)/|(//.***?$))">
>                                 <function
> -                                   mainExpr="(^func\s+[\w]+)|(^**
> func\s*\(\s*[\w]+\s+\*?\s*[\w]**+\s*\)\s*[\w]+)"
> +                                       mainExpr="(^func\s+\w+)|(^**
> func\s*\(\s*\w+\s*\*?\s*\w+\s***\)\s*\w+)"
>                                         displayMode="$className->$**
> functionName">
>                                         <functionName>
> -                                               <nameExpr
> expr="(((func)[\s][\w]+)|(\(\**s*[\w]+\s+\*?\s*[\w]+\s*\)\s*[**\w]+))"/>
> -                                               <nameExpr
> expr="(((func)[\s][\w]+)|(\)\**s*[\w]+))"/>
> -                                               <nameExpr
> expr="(([\s][\w]+)|(\)\s*[\w]+**))"/>
> -                                               <nameExpr expr="[\w]+"/>
> +                                               <nameExpr
> expr="((func\s+\w+)|(\)\s*\w+)**)"/>
> +                                               <nameExpr
> expr="((\s+\w+)|(\)\s*\w+))"/>
> +                                               <nameExpr expr="\w+"/>
>                                         </functionName>
>                                         <className>
> -                                               <nameExpr
> expr="\(\s*[\w]+\s+\*?\s*[\w]+**\s*\)\s*[\w]+"/>
> -                                               <nameExpr
> expr="\(\s*[\w]+\s+\*?\s*[\w]+**\s*\)"/>
> -                                               <nameExpr
> expr="[\w]+\s+\*?\s*[\w]+\s*\)**"/>
> -                                               <nameExpr
> expr="\*?\s*[\w]+\s*\)"/>
> -                                               <nameExpr
> expr="[\w]+\s*\)"/>
> -                                               <nameExpr expr="[\w]+"/>
> +                                               <nameExpr expr="\w+\s*\)"/>
> +                                               <nameExpr expr="\w+"/>
>                                         </className>
>                                 </function>
>                         </parser>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

bradfitz

11 years, 7 months ago (2013-08-06 14:57:56 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=1169c3ec0059 ***

misc/notepadplus: simplify Function List regex

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12508043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages