Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1115)

Issue 12504044: code review 12504044: bufio: add Writer example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

bufio: add Writer example Update issue 5530

Patch Set 1 #

Patch Set 2 : diff -r 9bac75fea9e2 https://code.google.com/p/go #

Patch Set 3 : diff -r 00a411da5f5a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/pkg/bufio/example_test.go View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-08-12 02:38:26 UTC) #1
r
What's wrong with 12688044 other than not being submitted yet?
10 years, 9 months ago (2013-08-12 02:52:06 UTC) #2
r
And now it's submitted. So we just need the example now.
10 years, 9 months ago (2013-08-12 02:53:06 UTC) #3
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 9 months ago (2013-08-12 02:54:38 UTC) #4
r
LGTM
10 years, 9 months ago (2013-08-12 03:02:46 UTC) #5
adg
10 years, 9 months ago (2013-08-12 03:03:59 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=d7db8c804ffa ***

bufio: add Writer example

Update issue 5530

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12504044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b