Issue 12502044: code review 12502044: net: fix intentional build breakage introduced in 12413043

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12502044: code review 12502044: net: fix intentional build breakage introduced in 12413043 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
brainman

CC:
golang-dev

Visibility:
Public.

Description

net: fix intentional build breakage introduced in 12413043

Patch Set 1 #

Patch Set 2 : diff -r 48f7c4dd87fe https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 48f7c4dd87fe https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/tcp_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-06 10:43:35 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=fbc1a650b595 *** net: fix intentional build breakage introduced in 12413043 R=alex.brainman CC=golang-dev ...

11 years, 7 months ago (2013-08-06 10:44:04 UTC) #2

brainman

This one is NOT LGTM. But you already have appropriate fix here https://codereview.appspot.com/12545043/. Alex

11 years, 7 months ago (2013-08-06 23:48:56 UTC) #3

dvyukov

11 years, 7 months ago (2013-08-07 09:24:45 UTC) #4

On Wed, Aug 7, 2013 at 3:48 AM,  <alex.brainman@gmail.com> wrote:
> This one is NOT LGTM. But you already have appropriate fix here
> https://codereview.appspot.com/12545043/.
>

I just wanted to fix the builders as soon as possible w/o waiting for
the slowest builder. And then update the code based on the results
later.

Expand All Messages | Collapse All Messages