Issue 12496043: code review 12496043: runtime: Use old reflect.call implementation from cgo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12496043: code review 12496043: runtime: Use old reflect.call implementation from cgo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by khr

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

runtime: Use old reflect.call implementation from cgo. Basically a partial rollback of 12053043 until I can figure out what is really going on. Fixes bug 6051.

Patch Set 1 #

Patch Set 2 : diff -r 58c839988402 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 58c839988402 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 58c839988402 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r a14c507d13e9 https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	misc/cgo/test/callback.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/cgocall.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 7 months ago (2013-08-06 00:51:54 UTC) #1

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=7500ec6996b7 *** runtime: Use old reflect.call implementation from cgo. Basically a partial ...

11 years, 7 months ago (2013-08-06 00:53:11 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages