Issue 124950043: code review 124950043: cmd/6g, cmd/8g: fix, test byte-sized magic multiply

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124950043: code review 124950043: cmd/6g, cmd/8g: fix, test byte-sized magic multiply (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by rsc

Modified:
9 years, 8 months ago

Reviewers:
r, gobot, minux

CC:
golang-codereviews, r, dfc, iant, remyoudompheng

Visibility:
Public.

Description

cmd/6g, cmd/8g: fix, test byte-sized magic multiply Credit to Rémy for finding and writing test case. Fixes issue 8325.

Patch Set 1 #

Patch Set 2 : diff -r a2381d5f297185f89ed27189b8572427e9e16460 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a2381d5f297185f89ed27189b8572427e9e16460 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 62969513e59efeacfe78250fe31c4ccd9b6c4ecb https://code.google.com/p/go/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
M	src/cmd/6g/ggen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6g/peep.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8g/peep.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue8325.go	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: dfc, iant, r, remyoudompheng), I'd like you to review this change to ...

9 years, 8 months ago (2014-08-08 19:33:10 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8e5ec6948793 *** cmd/6g, cmd/8g: fix, test byte-sized magic multiply Credit to Rémy ...

9 years, 8 months ago (2014-08-11 19:24:30 UTC) #3

gobot

This CL appears to have broken the darwin-386-cheney builder. See http://build.golang.org/log/722de8ca6dafae90054038d87c4c52d6c2d69734

9 years, 8 months ago (2014-08-11 19:25:58 UTC) #4

Yup. 386s don't have an R15. Roll back or fix? On Mon, Aug 11, 2014 ...

9 years, 8 months ago (2014-08-11 19:32:31 UTC) #5

minux

9 years, 8 months ago (2014-08-11 20:54:42 UTC) #6

On Mon, Aug 11, 2014 at 3:32 PM, Rob Pike <r@golang.org> wrote:

> Yup. 386s don't have an R15.
>
> Roll back or fix?

I mailed CL 129720043 for a fix. ./all.bash passed on linux/386 and
nacl/386.

Expand All Messages | Collapse All Messages