Issue 124890043: code review 124890043: go.blog: exclude gorilla example (fixes build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124890043: code review 124890043: go.blog: exclude gorilla example (fixes build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by dave

Modified:
9 years, 9 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go.blog: exclude gorilla example (fixes build) Fix the build on builders that do not have git installed. See discussion: https://groups.google.com/forum/#!topic/golang-dev/SAv_H7fJHkw

Patch Set 1 #

Patch Set 2 : diff -r 3ede82aea9fd https://code.google.com/p/go.blog #

Patch Set 3 : diff -r 3ede82aea9fd https://code.google.com/p/go.blog #

Patch Set 4 : diff -r 3ede82aea9fd https://code.google.com/p/go.blog #

Patch Set 5 : diff -r 3ede82aea9fd https://code.google.com/p/go.blog #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/context/gorilla/gorilla.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog

9 years, 9 months ago (2014-08-08 01:03:15 UTC) #1

dave_cheney.net

9 years, 9 months ago (2014-08-08 01:06:55 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=7bb9f928b36d&repo=blog ***

go.blog: exclude gorilla example (fixes build)

Fix the build on builders that do not have git installed.

See discussion: https://groups.google.com/forum/#!topic/golang-dev/SAv_H7fJHkw

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/124890043

Expand All Messages | Collapse All Messages