Issue 12485044: code review 12485044: undo CL 12486043 / ab644299d124

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12485044: code review 12485044: undo CL 12486043 / ab644299d124 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

undo CL 12486043 / ab644299d124 Uglier. ««« original CL description all: use strings.IndexByte instead of Index where possible R=golang-dev, khr CC=golang-dev https://codereview.appspot.com/12486043 »»»

Patch Set 1 #

Patch Set 2 : diff -r ab644299d124 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ab644299d124 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -36 lines)			Patch
M	src/pkg/crypto/x509/pem_decrypt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/debug/gosym/symtab.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/json/tags.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/xml/typeinfo.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/encoding/xml/xml.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/build/build.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/big/rat.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/mime/mediatype.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/http/cgi/child.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/cookie.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/http/fs.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/request.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/http/server.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/url/url.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/os/os_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/user/lookup_unix.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/path/match.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/regexp/exec_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/regexp/regexp.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/unicode/maketables.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-05 23:07:51 UTC) #1

bradfitz

11 years, 7 months ago (2013-08-05 23:27:38 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=1bac09ef43f0 ***

undo CL 12486043 / ab644299d124

Uglier.

««« original CL description
all: use strings.IndexByte instead of Index where possible

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/12486043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/12485044

Expand All Messages | Collapse All Messages