code review 12485043: reflect: Get rid of the test for the error message when

reflect: Get rid of the test for the error message when
you do reflect.call with too big an argument list.
Not worth the hassle.

Fixes issue 6023
Fixes issue 6033

[khr, 2013-08-05 22:01:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[bradfitz, 2013-08-05 22:02:39]

LGTM



On Mon, Aug 5, 2013 at 3:01 PM, <khr@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> reflect: Get rid of the test for the error message when
> you do reflect.call with too big an argument list.
> Not worth the hassle.
>
> Please review this at
https://codereview.appspot.**com/12485043/<https://codereview.appspot.com/124...
>
> Affected files:
>   M src/pkg/reflect/all_test.go
>
>
> Index: src/pkg/reflect/all_test.go
> ==============================**==============================**=======
> --- a/src/pkg/reflect/all_test.go
> +++ b/src/pkg/reflect/all_test.go
> @@ -3509,14 +3509,3 @@
>  func (x *exhaustive) Maybe() bool {
>         return x.Choose(2) == 1
>  }
> -
> -func bigArgFunc(v [(1<<30)+64]byte) {
> -}
> -
> -func TestBigArgs(t *testing.T) {
> -       if !testing.Short() && ^uint(0)>>32 != 0 { // test on 64-bit only
> -               v := new([(1<<30)+64]byte)
> -               bigArgFunc(*v) // regular calls are ok
> -               shouldPanic(func()
{ValueOf(bigArgFunc).Call([]**Value{ValueOf(*v)})})
> // ... just not reflect calls
> -       }
> -}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dave_cheney.net, 2013-08-05 22:03:18]

LGTM. Please add the issue linkage from

https://codereview.appspot.com/12484043/

On Tue, Aug 6, 2013 at 8:02 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
>
>
> On Mon, Aug 5, 2013 at 3:01 PM, <khr@golang.org> wrote:
>>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://khr%40golang.org@code.google.com/p/go/
>>
>>
>> Description:
>> reflect: Get rid of the test for the error message when
>> you do reflect.call with too big an argument list.
>> Not worth the hassle.
>>
>> Please review this at https://codereview.appspot.com/12485043/
>>
>> Affected files:
>>   M src/pkg/reflect/all_test.go
>>
>>
>> Index: src/pkg/reflect/all_test.go
>> ===================================================================
>> --- a/src/pkg/reflect/all_test.go
>> +++ b/src/pkg/reflect/all_test.go
>> @@ -3509,14 +3509,3 @@
>>  func (x *exhaustive) Maybe() bool {
>>         return x.Choose(2) == 1
>>  }
>> -
>> -func bigArgFunc(v [(1<<30)+64]byte) {
>> -}
>> -
>> -func TestBigArgs(t *testing.T) {
>> -       if !testing.Short() && ^uint(0)>>32 != 0 { // test on 64-bit only
>> -               v := new([(1<<30)+64]byte)
>> -               bigArgFunc(*v) // regular calls are ok
>> -               shouldPanic(func()
>> {ValueOf(bigArgFunc).Call([]Value{ValueOf(*v)})}) // ... just not reflect
>> calls
>> -       }
>> -}
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[khr, 2013-08-05 22:08:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=58c839988402 ***

reflect: Get rid of the test for the error message when
you do reflect.call with too big an argument list.
Not worth the hassle.

Fixes issue 6023
Fixes issue 6033

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/12485043

[dvyukov, 2013-08-06 08:11:50]

You can construct a fake 4GB array w/o backing storage using unsafe. Since the
call must not happen, it should be good enough.