Issue 12478043: code review 12478043: runtime: use gcpc/gcsp during traceback of goroutines i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12478043: code review 12478043: runtime: use gcpc/gcsp during traceback of goroutines i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: use gcpc/gcsp during traceback of goroutines in syscalls gcpc/gcsp are used by GC in similar situation. gcpc/gcsp are also more stable than gp->sched, because gp->sched is mutated by entersyscall/exitsyscall in morestack and mcall. So it has higher chances of being inconsistent. Also, rename gcpc/gcsp to syscallpc/syscallsp. This is the same as reverted change 12250043 with save marked as textflag 7. The problem was that if save calls morestack, then subsequent lessstack spoils g->sched.pc/sp. And that bad values were remembered in g->syscallpc/sp. Entersyscallblock had the same problem, but it was never triggered to date.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -33 lines)			Patch
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2 3	5 chunks	+20 lines, -20 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-05 20:19:32 UTC) #1

dvyukov

11 years, 7 months ago (2013-08-06 09:39:25 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a29203f71b1f ***

runtime: use gcpc/gcsp during traceback of goroutines in syscalls
gcpc/gcsp are used by GC in similar situation.
gcpc/gcsp are also more stable than gp->sched,
because gp->sched is mutated by entersyscall/exitsyscall
in morestack and mcall. So it has higher chances of being inconsistent.
Also, rename gcpc/gcsp to syscallpc/syscallsp.

This is the same as reverted change 12250043
with save marked as textflag 7.
The problem was that if save calls morestack,
then subsequent lessstack spoils g->sched.pc/sp.
And that bad values were remembered in g->syscallpc/sp.
Entersyscallblock had the same problem,
but it was never triggered to date.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12478043

Expand All Messages | Collapse All Messages