code review 124550043: runtime: allow copying of onM frame

runtime: allow copying of onM frame
Currently goroutines in onM can't be copied/shrunk
(including the very goroutine that triggers GC).
Special case onM to allow copying.

[dvyukov, 2014-08-18 17:18:17]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[DMorsing, 2014-08-18 19:37:06]

LGTM.

[khr, 2014-08-18 20:26:05]

On 2014/08/18 19:37:06, DMorsing wrote:
> LGTM.

LGTM.

[rsc, 2014-08-18 22:57:23]

https://codereview.appspot.com/124550043/diff/40001/src/pkg/runtime/stack.c
File src/pkg/runtime/stack.c (right):

https://codereview.appspot.com/124550043/diff/40001/src/pkg/runtime/stack.c#n...
src/pkg/runtime/stack.c:429: // A special routine at the BOS of a routine that
does onM call.
BOS is not defined anywhere. Just write out "bottom of stack".

[dvyukov, 2014-08-19 10:23:15]

https://codereview.appspot.com/124550043/diff/40001/src/pkg/runtime/stack.c
File src/pkg/runtime/stack.c (right):

https://codereview.appspot.com/124550043/diff/40001/src/pkg/runtime/stack.c#n...
src/pkg/runtime/stack.c:429: // A special routine at the BOS of a routine that
does onM call.
On 2014/08/18 22:57:22, rsc wrote:
> BOS is not defined anywhere. Just write out "bottom of stack".

Done.

[dvyukov, 2014-08-19 10:24:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=9a3b7b108ad3 ***

runtime: allow copying of onM frame
Currently goroutines in onM can't be copied/shrunk
(including the very goroutine that triggers GC).
Special case onM to allow copying.

LGTM=daniel.morsing, khr
R=golang-codereviews, daniel.morsing, khr, rsc
CC=golang-codereviews, rlh
https://codereview.appspot.com/124550043

[gobot, 2014-08-19 10:34:12]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/8c8243c15aa65a700aa9e9c60ae6a6d01ef336c7